Updated with requirements for openblas dependency#20956
Merged
adamjstewart merged 2 commits intospack:developfrom Jan 18, 2021
G-Ragghianti:blaspp
Merged
Updated with requirements for openblas dependency#20956adamjstewart merged 2 commits intospack:developfrom G-Ragghianti:blaspp
adamjstewart merged 2 commits intospack:developfrom
G-Ragghianti:blaspp
Conversation
adamjstewart
approved these changes
Jan 18, 2021
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
* Updated with requirements for openblas dependency * Python style fixes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves communication of the requirements of the package when compiling against openblas. For openblas versions greater than 0.3.5 we require "threads=openmp" or "threads=pthreads" for the blaspp tests to pass.
@ax3l @mgates3