Merged
Conversation
alalazo
approved these changes
Jan 6, 2021
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these Xorg
*protopackages are header-only packages. Back when I wrote #1740, I made the mistake of thinking that these could be uninstalled after installation, and therefore they should betype='build'. In reality, in order for Spack's compiler wrappers to work, these need to betype='link'. This has been fixed for some packages already, but this PR fixes the remaining packages.