Merged
Conversation
tldahlgren
reviewed
Jan 4, 2021
|
|
||
| To install this package, list it as an external package in packages.yaml, | ||
| and make sure to load the correct cray-fftw module. In some cases you | ||
| need to load cray-mpich before cray-fftw. |
Contributor
There was a problem hiding this comment.
Curious: Can these cases be specified as dependencies?
Member
Author
There was a problem hiding this comment.
I'm afraid it's not being picked up, and we should really fix that. If I add depends_on('cray-mpich') and register cray-mpich as external + not buildable + specify a module, I'm not getting it to load:
$ spack build-env fftw-example@develop %gcc@:8 ^[email protected] -- /bin/bash -c 'module list |& grep mpich'
.. nothing ..
Also as mentioned above, the order in which modules are loaded is important. It took me a while to figure out that running module load cray-fftw and then module load cray-mpich causes troubles with GCC because Cray likes to add -Wl,--as-needed to all kinds of libs, and that makes linking order important 😓
Contributor
|
Thank you for your contribution! |
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a wrapper package for cray-fftw.