ParaView: Allow choosing a CUDA architecture.#20623
Conversation
This is useful when the "native" architecture cannot be guessed.
3ab4fe1 to
f838b31
Compare
| description='Use module kits') | ||
| variant('cuda_arch', default='native', multi=False, | ||
| values=('native', 'fermi', 'kepler', 'maxwell', | ||
| 'pascal', 'volta', 'turing', 'all', 'none'), |
There was a problem hiding this comment.
Is there a reason to skip ampere, which is supported by two of vtk-m's options (80 and 86)?
There was a problem hiding this comment.
Hmm, I think I have looked at the code from the latest version of vtk-m and seen no mention of ampere: https://gitlab.kitware.com/vtk/vtk-m/-/blob/v1.5.1/CMake/VTKmDeviceAdapters.cmake#L161.
It seems to be in the master branch though so I can add it to be future-proof.
There was a problem hiding this comment.
I was just looking at the vtk-m package so was more curious. I haven't investigated when the ampere options were added.
There was a problem hiding this comment.
IMO that can be addressed in a subsequent PR if it becomes an issue.
|
Thank you for your contribution! |
This is useful when the "native" architecture cannot be guessed.
This is useful when the "native" architecture cannot be guessed.
|
@RemiLacroix-IDRIS The (When I try concretizing nalu-wind in spack with the clingo concretizer, I see an error: ) |
|
@sethrj: I think I was aware of it but didn't think much about it back then. Before my change the I think there are probably some other cases like this where the "native" CUDA arch understood by the build script was preferred over the generic CUDA arch inherited from Spack. |
|
@sethrj @RemiLacroix-IDRIS this is being resolved at #23257. The reason of the ParaView pkg having a |
|
OK, so perhaps the error I'm getting is a problem with the concretizer rather than the override. Thanks! |
This is useful when the "native" architecture cannot be guessed.