dealii: fix concretization problem between trilinos and adol-c#20606
Merged
alalazo merged 2 commits intospack:developfrom Jan 6, 2021
Merged
dealii: fix concretization problem between trilinos and adol-c#20606alalazo merged 2 commits intospack:developfrom
alalazo merged 2 commits intospack:developfrom
Conversation
luca-heltai
changed the title
luca-heltai
force-pushed
the
fix-dealii-trilinos-conflict
branch
from
aab11ac to
74bd27c
Compare
jppelteret
reviewed
Dec 30, 2020
Comment on lines
+162
to
+163
| # FIXME: next line fixes concretization with trilinos and adol-c | ||
| depends_on('trilinos~exodus~netcdf', when='@9.0:+adol-c') |
Contributor
There was a problem hiding this comment.
Makes sense, due to the added the conflicts. But shouldn't this be when='@9.0:+adol-c+trilinos'?
Also, could we please put this further down the list (~line 199 with the other trilinos depends)? That way this list remains (nearly) alphabetically ordered.
Contributor
There was a problem hiding this comment.
Thanks for the fix, BTW :-)
jppelteret
approved these changes
Dec 31, 2020
Contributor
jppelteret
left a comment
jppelteret
left a comment
There was a problem hiding this comment.
Thanks @luca-heltai! LGTM :-)
alalazo
approved these changes
Jan 6, 2021
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20445