package magma: Remove -W args from CMakeLists.txt#20516
Merged
alalazo merged 1 commit intospack:developfrom Jan 6, 2021
Merged
package magma: Remove -W args from CMakeLists.txt#20516alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
Contributor
|
I would only suggest to make this specific to NVHPC compiler. Otherwise this patch would increase the number of warnings for the GCC compilers used by earlier CUDA releases. Something like this: |
Contributor
Author
Sure I could limit this to NVHPC, but I think the current version should not increase the number of warnings, as |
jkelling
force-pushed
the
magma_cmake_remove_Wargs
branch
from
f934aa2 to
47a9a8f
Compare
Contributor
Author
|
Updated to apply patch only for nvhpc (all versions) |
jkelling
force-pushed
the
magma_cmake_remove_Wargs
branch
from
47a9a8f to
26812c2
Compare
luszczek
approved these changes
Jan 5, 2021
alalazo
approved these changes
Jan 6, 2021
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmake buildsystem of magma (2.5.x) explicitly adds
-Wno-unused-functiontoCXXFLAGSandCFLAGS. The-W*are compiler specific, but the compiler is not checked. For me this broke installing it using NVHP/PGI.As compiler warnings are usually not interesting for spack users (who could also add them if needed), this PR adds a patch to the magma which removes the offending lines.