Skip to content

alps: fix for latest gcc and test bug#20462

Merged
adamjstewart merged 7 commits intospack:developfrom
ketsubouchi:bugfix/alps
Jan 6, 2021
Merged

alps: fix for latest gcc and test bug#20462
adamjstewart merged 7 commits intospack:developfrom
ketsubouchi:bugfix/alps

Conversation

@ketsubouchi
Copy link
Copy Markdown
Contributor

In order to support latest gcc

  • add #include <climits> to use INT_MAX
  • add temporally x
  • add this->
  • remove unused and obsolete style functions

Add NO_SYSTEM_ENVIRONMENT_PATH to test right time, not /usr/bin/time

Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have these patches been contributed upstream?

@ketsubouchi
Copy link
Copy Markdown
Contributor Author

I sent these patches to the ALPS mailing list.
https://lists.phys.ethz.ch/listinfo/comp-phys-alps-users

@adamjstewart adamjstewart merged commit 15a7723 into spack:develop Jan 6, 2021
bollig pushed a commit to bollig/spack that referenced this pull request Jan 12, 2021
* gcc build OK

* gcc mc-01 OK

* time test problem

* remove comment and debug

* use climit

* TAB to spaces

* comment
loulawrence pushed a commit to loulawrence/spack that referenced this pull request Jan 19, 2021
* gcc build OK

* gcc mc-01 OK

* time test problem

* remove comment and debug

* use climit

* TAB to spaces

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants