Skip to content

concretizer: emit facts for imposed dependencies#20426

Merged
tgamblin merged 4 commits intospack:refactor/asp-dependency-conditionsfrom
alalazo:features/move_rules_to_concretize_lp
Dec 20, 2020
Merged

concretizer: emit facts for imposed dependencies#20426
tgamblin merged 4 commits intospack:refactor/asp-dependency-conditionsfrom
alalazo:features/move_rules_to_concretize_lp

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Dec 16, 2020

I tried a couple of the suggestions I had for #20423 The main modifications here are:

  • Simplified and renamed a few ASP functions
  • depends_on clauses are numbered globally and identified only by ID
  • constraints imposed on the dependency are also turned into facts

@alalazo alalazo requested a review from tgamblin December 17, 2020 19:58
@alalazo alalazo force-pushed the features/move_rules_to_concretize_lp branch from 47777ae to bd2880b Compare December 17, 2020 21:55
@tgamblin tgamblin merged commit bd2880b into spack:refactor/asp-dependency-conditions Dec 20, 2020
@alalazo alalazo deleted the features/move_rules_to_concretize_lp branch December 20, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants