Merged
Conversation
Enabling PSATD is not mutually exclusive with other runtime options anymore, so we can always compile with support for it to ease usability.
ax3l
commented
Dec 11, 2020
| depends_on('pkgconfig', type='build', when='+openpmd') | ||
| depends_on('python', type='build') # AMReX' build system info | ||
| depends_on('openpmd-api@0.11.0:,dev', when='+openpmd') | ||
| depends_on('openpmd-api@0.12.0:,dev', when='+openpmd') |
Member
Author
There was a problem hiding this comment.
dependency update was needed
dpgrote
approved these changes
Dec 11, 2020
Contributor
dpgrote
left a comment
dpgrote
left a comment
There was a problem hiding this comment.
This is good, now that psatd is a run time option.
alalazo
approved these changes
Dec 14, 2020
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
Enabling PSATD is not mutually exclusive with other runtime options anymore, so we can always compile with support for it to ease usability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling PSATD is not mutually exclusive with other runtime options anymore, so we can always compile with support for it to ease usability.
cc @dpgrote @MaxThevenet @RemiLehe