Merged
Conversation
ChristianTackeGSI
force-pushed
the
pr/libc
branch
2 times, most recently
from
a928442 to
b09c316
Compare
Contributor
|
Closing and re-opening to force re-running checks since style appears to be hung. |
The C-Library for the current compiler should already be used by the compiler. So there is no point in returning any libs for this package. Without this patch: if one uses this as an external package (as intended), then this will can inject system library paths into the build process at the wrong place.
ChristianTackeGSI
force-pushed
the
pr/libc
branch
from
b09c316 to
0209dd4
Compare
Member
Author
|
@tldahlgren Thanks! Rebased and force-pushed. Maybe there are some updates in develop that help? |
Contributor
|
Thank you for your contribution! |
Member
Author
|
Thanks! |
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
The C-Library for the current compiler should already be used by the compiler. So there is no point in returning any libs for this package. Without this patch: if one uses this as an external package (as intended), then this will can inject system library paths into the build process at the wrong place.
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
The C-Library for the current compiler should already be used by the compiler. So there is no point in returning any libs for this package. Without this patch: if one uses this as an external package (as intended), then this will can inject system library paths into the build process at the wrong place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C-Library for the current compiler should already be used by the compiler. So there is no point in returning any libs for this package.
Without this patch: if one uses this as an external package (as intended), then this will can inject system library paths into the build process at the wrong place.