Merged
Conversation
Member
|
Thanks for the fix! I'm wondering though if you could move this into ? We're trying to keep track of transmitted state there |
added 2 commits
December 11, 2020 13:42
…rgs to the PackageInstallContext object.
benc303
force-pushed
the
bugfix/fixLogging
branch
from
b3adede to
7706217
Compare
scheibelp
approved these changes
Dec 11, 2020
Member
|
Thanks! |
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
This fixes a logging error observed on macOS 11.0.1 (Big Sur). When performing a Spack install in debugging mode (e.g. `spack -d install py-scipy`) Spack is supposed to write a log of compiler wrapper command line invocations to the current working directory. Due to a regression error introduced by spack#18205, these files were no-longer generated, and Spack was printing errors such as "No such file or directory: None/." This is because the log file directory gets set from `spack.main.spack_working_dir`, but that variable is not set in the spawned process. This PR ensures that the working directory (at the time of the "spack install" invocation) is persisted to the subprocess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a logging error, observed on macOS 11.0.1 (Big Sur). Running Spack in debugging mode, for instance
spack -dd install py-scipy, results in log files from the compiler wrappers not getting written, instead printing errors such as “No such file or directory: None/.” This is because the log file directory gets set fromspack.main.spack_working_dir, but that variable is not set in the spawned process. This PR passes the working directory into the subprocess throughkwargs, and then assignsspack.main.spack_working_dirto it, so that the logging directory is set correctly.