Fix: Renamed new vtk-m test method so picked up as a smoke test#20326
Closed
tldahlgren wants to merge 1 commit intodevelopfrom
Closed
Fix: Renamed new vtk-m test method so picked up as a smoke test#20326tldahlgren wants to merge 1 commit intodevelopfrom
tldahlgren wants to merge 1 commit intodevelopfrom
Conversation
tldahlgren
added
don't-merge-yet
stand-alone-tests
Contributor
Author
|
There's actually more needed for the tests to work as written than #20298. Spack has to make the spec information available to install tests. |
7 tasks
Member
|
Maintainer ping: @robertmaynard @kmorel @vicentebolea |
robertmaynard
approved these changes
Dec 28, 2020
Member
|
This seems to be outdated. Can we close it? |
Contributor
|
I agree. It looks like this was fixed independently with #29113. I will close this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package's smoke test won't be run by Spack as a smoke test -- though it will during installation -- due to the name given to the method. This PR simply renames the method.
This PR depends on #20298 to test whether renaming is sufficient to actually execute the test.
UPDATE: Making the information available to the test requires more changes to Spack to retain build dependencies for this purposes. The LLNL Spack team has begun discussing options.