AMD ROCm 3.10 Release: Add new package recipe for rocm-openmp-extras.#20204
Merged
adamjstewart merged 7 commits intospack:developfrom Jan 5, 2021
Merged
AMD ROCm 3.10 Release: Add new package recipe for rocm-openmp-extras.#20204adamjstewart merged 7 commits intospack:developfrom
adamjstewart merged 7 commits intospack:developfrom
Conversation
Contributor
Author
|
Looks like I cannot add a reviewer. Would like @adamjstewart to review. AMD label will be added. |
adamjstewart
reviewed
Dec 1, 2020
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
@haampie might want to review this
There seems to be a lot of overlap between this package and LLVM, so pinging @naromero77 @trws
Contributor
|
Is this package in support of the AMD compiler? |
alalazo
previously requested changes
Dec 4, 2020
Contributor
Author
|
Thanks for the feedback. I had a long response/explanation written, but need to look into one issue further so I can provide more clarity for you on the llvm overlap here. |
Changed name to rocm-openmp-extras. Reduced repitition with component hashes. Adjusted the removal of CMAKE_BUILD_TYPE. Reduced repitition in cmake args. Added 3.10.0 to recipe.
estewart08
changed the title
Contributor
Author
|
Updated the recipe with suggested changes, see commits for details. I was able to remove the re-build of llvm-amdgpu. |
adamjstewart
approved these changes
Dec 18, 2020
Contributor
|
@adamjstewart @haampie Can you help getting this approved/merged? anything pending on this ? |
Member
|
See my comment on |
Contributor
Author
|
This all set to merge now? |
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
…spack#20204) * AMD ROCm 3.9 Release: Add new package recipe for openmp-extras. * Updated openmp-extras recipe. Changed name to rocm-openmp-extras. Reduced repitition with component hashes. Adjusted the removal of CMAKE_BUILD_TYPE. Reduced repitition in cmake args. Added 3.10.0 to recipe. * Update python/py-setuptools dependency versions. * Expand dependency versions, fix the openmp cmake args. * Remove double formats. * Substitute escape characters with string=True for filter_file(s). * Remove CMAKE_VERBOSE_MAKEFILE, already present in standard args.
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
…spack#20204) * AMD ROCm 3.9 Release: Add new package recipe for openmp-extras. * Updated openmp-extras recipe. Changed name to rocm-openmp-extras. Reduced repitition with component hashes. Adjusted the removal of CMAKE_BUILD_TYPE. Reduced repitition in cmake args. Added 3.10.0 to recipe. * Update python/py-setuptools dependency versions. * Expand dependency versions, fix the openmp cmake args. * Remove double formats. * Substitute escape characters with string=True for filter_file(s). * Remove CMAKE_VERBOSE_MAKEFILE, already present in standard args.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.