add build dependency on autoconf/automake/libtool for mpich#20176
Merged
alalazo merged 1 commit intospack:developfrom Dec 1, 2020
Merged
add build dependency on autoconf/automake/libtool for mpich#20176alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
Member
Author
|
Hm, there's already a conditional dependency on autoconf and friends, but apparently the |
Issue is fixed in 3.4.x
Member
Author
|
Current develop: This PR: $ spack debug report
With the old concretizer on either develop or this PR: So ping @alalazo for a potential concretizer issue 😅. In any case, this PR could still be OK as a temporary fix. |
Member
Author
|
Ugh, it's worse even... notice how the new concretizer picks libtool@develop with this PR :( |
Member
|
@haampie Do you have any custom configuration? That's what I see: $ spack solve mpich
==> Best of 0 answers.
==> Optimization: [0, 0, -13, 20, 0, 0, -28, 1, 1, 0, -25, 0]
[email protected]%[email protected]~argobots+fortran+hwloc+hydra+libxml2+pci+romio~slurm~verbs+wrapperrpath device=ch3 netmod=tcp patches=eb982de3366d48cbc55eb5e0df43373a45d9f51df208abf0835a72dc6c0b4774 pmi=pmi arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] patches=84b916c0bf8c51b7e7b28417692f0ad3e7030d1f3c248ba77c42ede5c1c5d11e,bd9e4e5cc280f9753ae14956c4e4aa17fe7a210f55dd6c84aa60b12d106d47a2 arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+sigsegv patches=3877ab548f88597ab2327a2230ee048d2d07ace1062efe81fc92e91b7f39cd00,fc9b61654a3ba1a8d6cd78ce087e7c96366c290bc8d2c299f09828d793b853c8 arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+cpanm+shared+threads arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] patches=7f569b9287e9e5a4236636eef32ff3428f0462ec17aea359e0ebee07649f1f16 arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]~symlinks+termlib arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+bzip2+curses+git~libunistring+libxml2+tar+xz arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+shared arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]~python arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]~pic arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]+optimize+pic+shared arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] patches=12f6edb0c6b270b8c8dba2ce17998c580db01182d871ee32b7b6e4129bd1d23a,1732115f651cff98989cb0215d8f64da5e0f7911ebf0c13b064920f088f2ffe1 arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected]~cairo~cuda~gl~libudev+libxml2~netloc~nvml+pci+shared arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
^[email protected]%[email protected] arch=linux-ubuntu18.04-broadwell
|
Member
Author
|
That's on develop? It seems the autoconf/automake/libtool are not direct dependencies of mpich in your concretization, just like it was for me, which is why I created the PR |
alalazo
approved these changes
Dec 1, 2020
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
Issue is fixed in 3.4.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my case mpich 3.3.2 does not build, because a patch triggers autoconf to be called again, and autoconf is not a direct build dependency of mpich. This PR adds an unconditional dependency on the autotools build packages, since findutils is a dependency of mpich already, and it depends on those packages anyways.