added 'binary_index_root' entry in config#20137
Closed
mslacken wants to merge 1 commit intospack:developfrom
Closed
added 'binary_index_root' entry in config#20137mslacken wants to merge 1 commit intospack:developfrom
mslacken wants to merge 1 commit intospack:developfrom
Conversation
vvolkl
requested changes
Nov 29, 2020
Contributor
vvolkl
left a comment
vvolkl
left a comment
There was a problem hiding this comment.
Thanks @mslacken, that's great -- I was also just looking into installing spack on a read-only filesystem, and hit the same problem (actually it was only this path and the junit-report that had to be fixed, I'll make a PR for the latter).
Comment on lines
+85
to
+86
| # binary caches. Default location is $spack/opt/spack/indices | ||
| # binary_index_root: ~/.spack/indices |
Contributor
There was a problem hiding this comment.
Suggested change
| # binary caches. Default location is $spack/opt/spack/indices | |
| # binary_index_root: ~/.spack/indices | |
| # binary caches. In case $spack is read-only, set to a writeable directory, like ~/.spack/indices. | |
| binary_index_root: $spack/opt/spack/indices |
Convention seems to be to explicitly set the default here (this makes the default value that is set in lib/spack/spack/binary_distribution.py ineffective, maybe remove there?)
Contributor
|
I believe this was obsoleted after discussion in #22500! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20136 by adding the
binary_index_rootentry to the default config.