Skip to content

[openloops] fix variant for clingo concretizer#20088

Closed
vvolkl wants to merge 1 commit intospack:developfrom
vvolkl:openloops-new-concretizer
Closed

[openloops] fix variant for clingo concretizer#20088
vvolkl wants to merge 1 commit intospack:developfrom
vvolkl:openloops-new-concretizer

Conversation

@vvolkl
Copy link
Copy Markdown
Contributor

@vvolkl vvolkl commented Nov 25, 2020

@iarspider Currently the new concretizer gets confused whether num_jobs is a single- or multi-valued variant and errors with:

==> Error: 'SingleValuedVariant' object has no attribute 'append'

this makes it explicitly a mulit-valued variant.

@iarspider
Copy link
Copy Markdown
Contributor

@vvolkl thanks for the fix. However, I'm not sure if limiting njobs to just 1 or 0 is enough (is there a way to query number of CPUs available?). Also, did you check if OpenLoops installer correctly handles num_jobs = 0?

@vvolkl
Copy link
Copy Markdown
Contributor Author

vvolkl commented Nov 25, 2020

@iarspider In my builds I always use 1, so I can't comment on 0 (in theory it should use all of them https://gitlab.com/openloops/OpenLoops/blob/master/openloops.cfg.tmpl#L9). I'm not sure other values for num_jobs will ever be needed but I'm happy to add some more, maybe 2**n up to 128?

aweits added a commit to aweits/spack that referenced this pull request Nov 25, 2020
aweits added a commit to aweits/spack that referenced this pull request Nov 27, 2020
aweits added a commit to aweits/spack that referenced this pull request Dec 1, 2020
aweits added a commit to aweits/spack that referenced this pull request Dec 2, 2020
aweits added a commit to aweits/spack that referenced this pull request Dec 3, 2020
aweits added a commit to aweits/spack that referenced this pull request Dec 4, 2020
@vvolkl vvolkl deleted the openloops-new-concretizer branch December 8, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants