Add "hep" label to high energy physics packages#19968
Merged
drbenmorgan merged 2 commits intospack:developfrom Nov 18, 2020
Merged
Add "hep" label to high energy physics packages#19968drbenmorgan merged 2 commits intospack:developfrom
drbenmorgan merged 2 commits intospack:developfrom
Conversation
vvolkl
changed the title
drbenmorgan
approved these changes
Nov 18, 2020
Member
drbenmorgan
left a comment
drbenmorgan
left a comment
There was a problem hiding this comment.
This is great, thanks @vvolkl!
I'm happy to merge unless you want to go through further and identify any further packages (but we can always tag more later as/when identified).
Contributor
Author
|
Thanks for the review, I searched the PRs for authors I know to be connected to HEP, and grepped for "particle", which also turned up a few packages I didn't know were in spack. To me it looks like I tagged pretty much everything, but with the number of packages in spack it is hard to be sure. But I agree, we can still tag things later if needed, so I think this can be merged. |
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
* [hep] add hep tag to relevant packages * [lcio] add hep label
wdconinc
pushed a commit
to eic/spack
that referenced
this pull request
Apr 8, 2021
* [hep] add hep tag to relevant packages * [lcio] add hep label
wdconinc
pushed a commit
to eic/spack
that referenced
this pull request
Apr 8, 2021
* [hep] add hep tag to relevant packages * [lcio] add hep label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I got all of them. -- should help with maintenance and adoption by the community.