add test to ensure that all packages can be pickled#19890
Merged
scheibelp merged 2 commits intospack:developfrom Nov 12, 2020
Merged
add test to ensure that all packages can be pickled#19890scheibelp merged 2 commits intospack:developfrom
scheibelp merged 2 commits intospack:developfrom
Conversation
… test keeps going and collects the names of all failed packages. It then takes the first one and attempts to re-pickle it, generating the full stacktrace from the failed pickle attempt
adamjstewart
approved these changes
Nov 12, 2020
tgamblin
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #18205 (merged today November 12), all packages must be pickle-able to be installed by Spack.
This adds a test to check that each package can be pickled. If any package fails to pickle, the test keeps going and collects the names of all failed packages; it then takes the first one that failed and attempts to re-pickle it, generating the full stacktrace for the failed pickle attempt.