Don't use prefix.lib in tcl/tk/glib/etc#19761
Merged
alalazo merged 9 commits intospack:developfrom Nov 14, 2020
Merged
Conversation
adamjstewart
commented
Nov 5, 2020
Comment on lines
+112
to
+115
| # Tcl libraries may be installed in lib or lib64, see #19546 | ||
| for lib in ['lib', 'lib64']: | ||
| tcl_paths.append(join_path( | ||
| d.prefix, lib, 'tcl{0}'.format(self.version.up_to(2)))) |
Member
Author
|
I believe the remaining build failures were present before this PR, they aren't introduced by this PR. So I think this is ready for review. Another question worth asking is if we should remove all uses of |
This comment has been minimized.
This comment has been minimized.
4 tasks
This comment has been minimized.
This comment has been minimized.
Contributor
|
It seems to work now. Thanks. |
alalazo
approved these changes
Nov 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19546
Packages I would like to have tested before merging:
@andymwood can you help test this on your system?