Merged
Conversation
Member
Author
|
ping: @adrienbernede |
[arpack-ng] Add a patch to fix building with IBM XL Fortran. [libceed] Fix building with IBM XL C/C++. [pumi] Add C++11 flag for version 2.2.3.
Reported by: @MPhysXDev
3 tasks
3 tasks
Resolved conflicts: var/spack/repos/builtin/packages/libceed/package.py var/spack/repos/builtin/packages/mfem/package.py
Member
Author
|
Merging this PR in another PR: #22735. |
Member
Author
|
Restoring the branch temporarily. Will delete again when no longer needed. |
tzanio
pushed a commit
that referenced
this pull request
Jun 3, 2021
* petsc: add hip variant * libceed: add 0.8, disable occa by default, and let autodetect AVX Disabling OCCA because backend updates did not make this release and there are some known bugs so most users won't have reason to use OCCA. CEED/libCEED#688 * WIP: ceed: 4.0 release * MFEM package updates (#19748) * MFEM package updates * mfem: flake8 * [mfem] Various fixes and tweaks. [arpack-ng] Add a patch to fix building with IBM XL Fortran. [libceed] Fix building with IBM XL C/C++. [pumi] Add C++11 flag for version 2.2.3. * [mfem] Fix the shared CUDA build. Reported by: @MPhysXDev * [mfem] Fix a TODO item * [mfem] Tweak the AmgX dependencies * [suite-sparse] Fix the version of the mpfr dependency * MFEM: add initial HIP support using the ROCmPackage. * MFEM: add 'slepc' variant. * MFEM: update the patch for v4.2 for SLEPc. * mfem: apply 'mfem-4.2-slepc.patch' just to v4.2. * ceed: apply 'spack style' * [mfem] Add a patch for mfem v4.2 to work with petsc v3.15.0. [laghos] Add laghos version 3.1 based on the latest commit in the repository; this version works with mfem v4.2. [ceed] For ceed v4.0 use laghos v3.1. * [libceed] Explicitly set 'CC_VENDOR=icc' when using 'intel' compiler. * [mfem] Allow pumi >= 2.2.3 with mfem >= 4.2.0. [ceed] Use pumi v2.2.5 with ceed v4.0.0. * [ceed] Explicitly use occa v1.1.0 with ceed v4.0.0. Use [email protected]+rocm with [email protected]+mfem+hip. * [ceed] Add NekRS v21 as a dependency for ceed v4.0.0. * [ceed] Fix NekRS version: 21 --> 21.0 * [ceed] Propagate +cuda variant to petsc for ceed v4.0. * [mfem] Propagate '+rocm' variant to some other packages. * [ceed] Use +rocm variant of nekrs instead of +hip. * [ceed] Do not enable magma with [email protected]+hip. * [libceed] Fix hip build with [email protected]. * [laghos] For v3.1, use the release .tar.gz file instead of commit. * Remove cuda & hip variants as they are inherited * [ceed] Remove comments and FIXMEs about 'magma+hip'. * [ceed] [libceed] Remove TODOs about occa + hip. * libceed: use ROCmPackage and +rocm * petsc: use ROCmPackage for HIP * libceed, petsc: use CudaPackage * ceed: forward cuda_arch and amdgpu_target * [mfem] Use Spack's CudaPackage as a base class; as a result, 'cuda_arch' values should not include the 'sm_' prefix. Also, propagate 'cuda_arch' and 'amdgpu_target' variants to enabled dependencies. * petsc: variant is +rocm, package name is hip Co-authored-by: Jed Brown <[email protected]> Co-authored-by: Thilina Rathnayake <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jun 9, 2021
* petsc: add hip variant * libceed: add 0.8, disable occa by default, and let autodetect AVX Disabling OCCA because backend updates did not make this release and there are some known bugs so most users won't have reason to use OCCA. CEED/libCEED#688 * WIP: ceed: 4.0 release * MFEM package updates (spack#19748) * MFEM package updates * mfem: flake8 * [mfem] Various fixes and tweaks. [arpack-ng] Add a patch to fix building with IBM XL Fortran. [libceed] Fix building with IBM XL C/C++. [pumi] Add C++11 flag for version 2.2.3. * [mfem] Fix the shared CUDA build. Reported by: @MPhysXDev * [mfem] Fix a TODO item * [mfem] Tweak the AmgX dependencies * [suite-sparse] Fix the version of the mpfr dependency * MFEM: add initial HIP support using the ROCmPackage. * MFEM: add 'slepc' variant. * MFEM: update the patch for v4.2 for SLEPc. * mfem: apply 'mfem-4.2-slepc.patch' just to v4.2. * ceed: apply 'spack style' * [mfem] Add a patch for mfem v4.2 to work with petsc v3.15.0. [laghos] Add laghos version 3.1 based on the latest commit in the repository; this version works with mfem v4.2. [ceed] For ceed v4.0 use laghos v3.1. * [libceed] Explicitly set 'CC_VENDOR=icc' when using 'intel' compiler. * [mfem] Allow pumi >= 2.2.3 with mfem >= 4.2.0. [ceed] Use pumi v2.2.5 with ceed v4.0.0. * [ceed] Explicitly use occa v1.1.0 with ceed v4.0.0. Use [email protected]+rocm with [email protected]+mfem+hip. * [ceed] Add NekRS v21 as a dependency for ceed v4.0.0. * [ceed] Fix NekRS version: 21 --> 21.0 * [ceed] Propagate +cuda variant to petsc for ceed v4.0. * [mfem] Propagate '+rocm' variant to some other packages. * [ceed] Use +rocm variant of nekrs instead of +hip. * [ceed] Do not enable magma with [email protected]+hip. * [libceed] Fix hip build with [email protected]. * [laghos] For v3.1, use the release .tar.gz file instead of commit. * Remove cuda & hip variants as they are inherited * [ceed] Remove comments and FIXMEs about 'magma+hip'. * [ceed] [libceed] Remove TODOs about occa + hip. * libceed: use ROCmPackage and +rocm * petsc: use ROCmPackage for HIP * libceed, petsc: use CudaPackage * ceed: forward cuda_arch and amdgpu_target * [mfem] Use Spack's CudaPackage as a base class; as a result, 'cuda_arch' values should not include the 'sm_' prefix. Also, propagate 'cuda_arch' and 'amdgpu_target' variants to enabled dependencies. * petsc: variant is +rocm, package name is hip Co-authored-by: Jed Brown <[email protected]> Co-authored-by: Thilina Rathnayake <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jun 11, 2021
* petsc: add hip variant * libceed: add 0.8, disable occa by default, and let autodetect AVX Disabling OCCA because backend updates did not make this release and there are some known bugs so most users won't have reason to use OCCA. CEED/libCEED#688 * WIP: ceed: 4.0 release * MFEM package updates (spack#19748) * MFEM package updates * mfem: flake8 * [mfem] Various fixes and tweaks. [arpack-ng] Add a patch to fix building with IBM XL Fortran. [libceed] Fix building with IBM XL C/C++. [pumi] Add C++11 flag for version 2.2.3. * [mfem] Fix the shared CUDA build. Reported by: @MPhysXDev * [mfem] Fix a TODO item * [mfem] Tweak the AmgX dependencies * [suite-sparse] Fix the version of the mpfr dependency * MFEM: add initial HIP support using the ROCmPackage. * MFEM: add 'slepc' variant. * MFEM: update the patch for v4.2 for SLEPc. * mfem: apply 'mfem-4.2-slepc.patch' just to v4.2. * ceed: apply 'spack style' * [mfem] Add a patch for mfem v4.2 to work with petsc v3.15.0. [laghos] Add laghos version 3.1 based on the latest commit in the repository; this version works with mfem v4.2. [ceed] For ceed v4.0 use laghos v3.1. * [libceed] Explicitly set 'CC_VENDOR=icc' when using 'intel' compiler. * [mfem] Allow pumi >= 2.2.3 with mfem >= 4.2.0. [ceed] Use pumi v2.2.5 with ceed v4.0.0. * [ceed] Explicitly use occa v1.1.0 with ceed v4.0.0. Use [email protected]+rocm with [email protected]+mfem+hip. * [ceed] Add NekRS v21 as a dependency for ceed v4.0.0. * [ceed] Fix NekRS version: 21 --> 21.0 * [ceed] Propagate +cuda variant to petsc for ceed v4.0. * [mfem] Propagate '+rocm' variant to some other packages. * [ceed] Use +rocm variant of nekrs instead of +hip. * [ceed] Do not enable magma with [email protected]+hip. * [libceed] Fix hip build with [email protected]. * [laghos] For v3.1, use the release .tar.gz file instead of commit. * Remove cuda & hip variants as they are inherited * [ceed] Remove comments and FIXMEs about 'magma+hip'. * [ceed] [libceed] Remove TODOs about occa + hip. * libceed: use ROCmPackage and +rocm * petsc: use ROCmPackage for HIP * libceed, petsc: use CudaPackage * ceed: forward cuda_arch and amdgpu_target * [mfem] Use Spack's CudaPackage as a base class; as a result, 'cuda_arch' values should not include the 'sm_' prefix. Also, propagate 'cuda_arch' and 'amdgpu_target' variants to enabled dependencies. * petsc: variant is +rocm, package name is hip Co-authored-by: Jed Brown <[email protected]> Co-authored-by: Thilina Rathnayake <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some outstanding issues and adds new variants.