add 0.6.0 conduit release and update for branch changes#19696
Merged
adamjstewart merged 1 commit intospack:developfrom Nov 18, 2020
Merged
add 0.6.0 conduit release and update for branch changes#19696adamjstewart merged 1 commit intospack:developfrom
adamjstewart merged 1 commit intospack:developfrom
Conversation
adamjstewart
reviewed
Nov 3, 2020
| version('develop', branch='develop', submodules=True, preferred=True) | ||
| # note: the main branch in conduit was renamed to develop, this next entry | ||
| # is to bridge any spack dependencies that are still using the name master | ||
| version('master', branch='develop', submodules=True) |
Member
There was a problem hiding this comment.
Why not fix spack dependencies that are still using the name master? I would rather be consistent.
Member
Author
There was a problem hiding this comment.
I don't think I have the visibility to tackle that with certainty. It could be specified in folks package.yaml files, etc.
Member
Author
There was a problem hiding this comment.
@adamjstewart -- can we get this merged in? Folks that were expecting to stay up-to-date with the main branch, will not longer be able to use spack to do so
adamjstewart
approved these changes
Nov 18, 2020
Member
Author
|
thanks! |
bollig
pushed a commit
to bollig/spack
that referenced
this pull request
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.