Fix fetch of spec.yaml files from buildcache#19101
Merged
scottwittenburg merged 1 commit intodevelopfrom Oct 1, 2020
Merged
Conversation
Since those files currently exist in buildcaches (in S3 buckets) with potentially different content types, we should be less restrictive in what content types we accept when attempting to fetch them. This PR removes the content type constraint so any file with the matching name will be found.
Contributor
Author
|
FYI @reviewers: The failure on the gitlab pipeline is unrelated to this PR. That failure is caused by #18196. Do I need to comment |
zackgalbreath
approved these changes
Oct 1, 2020
Contributor
Author
|
FYI @eugeneswalker |
robertu94
pushed a commit
to robertu94/spack
that referenced
this pull request
Oct 2, 2020
Since those files currently exist in buildcaches (in S3 buckets) with potentially different content types, we should be less restrictive in what content types we accept when attempting to fetch them. This PR removes the content type constraint so any file with the matching name will be found.
scottwittenburg
added a commit
that referenced
this pull request
Oct 5, 2020
This reverts commit d3d9807.
3 tasks
scheibelp
pushed a commit
that referenced
this pull request
Oct 5, 2020
This reverts #18359 and follow-on PRs intended to address issues with #18359 because that PR changes the hash of all specs. A future PR will reintroduce the changes. * Revert "Fix location in spec.yaml where we look for full_hash (#19132)" * Revert "Fix fetch of spec.yaml files from buildcache (#19101)" * Revert "Merge pull request #18359 from scottwittenburg/add-binary-distribution-cache-manager"
scottwittenburg
added a commit
that referenced
this pull request
Oct 6, 2020
Since those files currently exist in buildcaches (in S3 buckets) with potentially different content types, we should be less restrictive in what content types we accept when attempting to fetch them. This PR removes the content type constraint so any file with the matching name will be found.
scottwittenburg
added a commit
to scottwittenburg/spack
that referenced
this pull request
Oct 16, 2020
Since those files currently exist in buildcaches (in S3 buckets) with potentially different content types, we should be less restrictive in what content types we accept when attempting to fetch them. This PR removes the content type constraint so any file with the matching name will be found.
scottwittenburg
added a commit
to scottwittenburg/spack
that referenced
this pull request
Oct 23, 2020
Since those files currently exist in buildcaches (in S3 buckets) with potentially different content types, we should be less restrictive in what content types we accept when attempting to fetch them. This PR removes the content type constraint so any file with the matching name will be found.
scottwittenburg
added a commit
to scottwittenburg/spack
that referenced
this pull request
Oct 29, 2020
Since those files currently exist in buildcaches (in S3 buckets) with potentially different content types, we should be less restrictive in what content types we accept when attempting to fetch them. This PR removes the content type constraint so any file with the matching name will be found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since those files currently exist in buildcaches (in S3 buckets) with
potentially different content types, we should be less restrictive in
what content types we accept when attempting to fetch them. This PR
removes the content type constraint so any file with the matching
name will be found.