buildcache list: add listed specs to database as not installed#19085
buildcache list: add listed specs to database as not installed#19085
Conversation
Database.add: allow packages to be added without being marked installed
| @@ -1115,7 +1114,7 @@ def _add( | |||
|
|
|||
| else: | |||
| # If it is already there, mark it as installed. | |||
There was a problem hiding this comment.
Update comment with new behaviour
|
How does this work if the cache has 22,000+ entries? Does adding this many entries create a problem? |
|
I'm using this branch to run |
|
@eugeneswalker we could improve the performance of that command by doing a single write transaction with all of the specs to add, I'm more worried about the performance of |
|
I don't think the DB will necessarily be too big after this -- we already read the |
|
I ran it with debug output turned on. This was part of the final debug output: I feel like something is off. |
|
@eugeneswalker were any of the builds in the cache for the same architecture as the machine you ran it on? You could use the I've also pushed a commit that should improve the performance some. Can you run a |
|
Closing: we decided to solve this problem with a hash cache rather than adding to the database, because of scalability concerns with the json database. |
This allows the following worflow
Included work: Database.add: allow packages to be added without being marked installed