Skip to content

Update openblas to build with [email protected]#19057

Merged
scheibelp merged 1 commit intospack:developfrom
healther:PR/openblas
Oct 2, 2020
Merged

Update openblas to build with [email protected]#19057
scheibelp merged 1 commit intospack:developfrom
healther:PR/openblas

Conversation

@healther
Copy link
Copy Markdown
Contributor

@healther healther commented Sep 30, 2020

fixes #19041
fixes #18658

tested on
% spack debug report

  • Spack: 0.15.4-1204-15c41ed877
  • Python: 3.7.4
  • Platform: darwin-catalina-skylake

See discussion in OpenMathLib/OpenBLAS#2870 and comments in the diff

@@ -0,0 +1,384 @@
From 1a05523709567d54273fe1000ae4319df437737c Mon Sep 17 00:00:00 2001
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate the patch file from this commit: OpenMathLib/OpenBLAS@f42e84d

The one you used appears to have been a temporary one which does not belong to the develop branch of OpenBLAS.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add the patch via URL and sha256.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only tested that the patch applies and did not do another test build, I assume it still works fine, but can do another test build tomorrow at the earliest. Do you want me to or merge as is?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add the patch via URL and sha256.

Just for my understanding: Will a URL-based patch be included in the source cache?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a URL-based patch would be cached just like resources.

@healther
Copy link
Copy Markdown
Contributor Author

healther commented Oct 1, 2020

Test build complete and working

@scheibelp scheibelp merged commit 9644332 into spack:develop Oct 2, 2020
@healther healther deleted the PR/openblas branch October 3, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation issue: [email protected] on MacOSX Installation issue: openblas build failed

4 participants