Merged
Conversation
v-dobrev
reviewed
Oct 1, 2020
v-dobrev
reviewed
Oct 1, 2020
v-dobrev
approved these changes
Oct 1, 2020
Member
v-dobrev
left a comment
v-dobrev
left a comment
There was a problem hiding this comment.
Looks good. Feel to ignore or tweak my suggestions above.
Member
|
Another thought: I see that |
jedbrown
force-pushed
the
jed/libceed-0.7
branch
2 times, most recently
from
8b07b02 to
205bd43
Compare
jedbrown
force-pushed
the
jed/libceed-0.7
branch
from
205bd43 to
7cbe701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.