Trilinos: restrict SuperLU-dist version#19044
Merged
scheibelp merged 1 commit intospack:developfrom Oct 2, 2020
Merged
Conversation
SuperLU v6.3.0 changes the name of numerous structures, causing errors in Amesos up through Trilinos 13. ``` packages/amesos/src/Amesos_Superludist.cpp:50:3: error: 'ScalePermstruct_t' does not name a type; did you mean 'dScalePermstruct_t'? packages/amesos/src/Amesos_Superludist.cpp:51:3: error: 'LUstruct_t' does not name a type; did you mean 'dLUstruct_t'? packages/amesos/src/Amesos_Superludist.cpp:52:3: error: 'SOLVEstruct_t' does not name a type; did you mean 'dSOLVEstruct_t'? packages/amesos/src/Amesos_Superludist.cpp:166:47: error: 'class Amesos_Superlu_Pimpl' has no member named 'ScalePermstruct_' packages/amesos/src/Amesos_Superludist.cpp:166:5: error: 'ScalePermstructFree' was not declared in this scope packages/amesos/src/Amesos_Superludist.cpp:167:83: error: 'class Amesos_Superlu_Pimpl' has no member named 'LUstruct_' packages/amesos/src/Amesos_Superludist.cpp:167:5: error: 'Destroy_LU' was not declared in this scope packages/amesos/src/Amesos_Superludist.cpp:168:40: error: 'class Amesos_Superlu_Pimpl' has no member named 'LUstruct_' packages/amesos/src/Amesos_Superludist.cpp:168:5: error: 'LUstructFree' was not declared in this scope packages/amesos/src/Amesos_Superludist.cpp:170:76: error: 'class Amesos_Superlu_Pimpl' has no member named 'SOLVEstruct_' packages/amesos/src/Amesos_Superludist.cpp:426:47: error: 'class Amesos_Superlu_Pimpl' has no member named 'ScalePermstruct_' packages/amesos/src/Amesos_Superludist.cpp:426:5: error: 'ScalePermstructFree' was not declared in this scope ```
scheibelp
approved these changes
Oct 2, 2020
Contributor
Author
|
Thanks @scheibelp ! |
Member
|
You're welcome - thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuperLU v6.3.0 changes the name of numerous structures, causing errors
in Amesos up through Trilinos 13.