Merged
Conversation
Contributor
|
@ChristianTackeGSI agreed, that's a good idea. It seems in the lcg releases the default is still 244 (as of 98), but I think they'll follow suit. |
|
I also support moving to 8303 |
* Add version 8303 * Until now, the latest 82xx release was the `preferred` version. We agreed to let the latest version be the preferred one now.
ChristianTackeGSI
force-pushed
the
pr/pythia8
branch
from
e780fef to
f30cc2d
Compare
ChristianTackeGSI
changed the title
Member
Author
|
Thanks for your feedback! Two of three are good enough for me to switch the default version for |
michaelkuhn
approved these changes
Sep 24, 2020
tmadlener
added a commit
to tmadlener/k4-spack
that referenced
this pull request
Oct 8, 2020
whizard doesn't build with versions >= 2.8.5 pythia8 leads to a conflicting specs, since spack/spack#18874 has been merged and 8303 is the default version
vvolkl
pushed a commit
to key4hep/key4hep-spack
that referenced
this pull request
Oct 12, 2020
whizard doesn't build with versions >= 2.8.5 pythia8 leads to a conflicting specs, since spack/spack#18874 has been merged and 8303 is the default version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kresan, @michaelkuhn, and @vvolkl
8303 has been released and looking at http://home.thep.lu.se/~torbjorn/Pythia.html
So it seems, we can remove the
preferred=Truefrom version 8244. Would you agree? If so, I would augment this PR accordingly.