Classic Flang Master Update#18748
Conversation
|
@adamjstewart Can we get this merged in? |
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
I just have a couple of questions about default versions.
| maintainers = ['naromero77'] | ||
|
|
||
| version('master', branch='master') | ||
| version('master', branch='master', preferred=True) |
There was a problem hiding this comment.
We generally try to avoid defaulting to moving targets like master because it can't be checksummed. Is there a good reason for this change?
There was a problem hiding this comment.
Understood about the checksum.
Yeah, the last tag was back in 20190329 and many bugs have been fixed since then. I keep receiving Spack issues that are fixed in master, but everyone installs 20190329 because it is the default. The developers have not tagged a new release in over a year -- I have spoken to them about tagging a new release. I can speak to them about it again. But mostly I did have the bandwidth to keep reply to users to do spack install flang@master instead.
| maintainer = ['naromero77'] | ||
|
|
||
| version('master', branch='master') | ||
| version('release_90', branch='release_90') |
There was a problem hiding this comment.
I'm pretty sure 20190329 will still be installed by default. Is this what you want?
There was a problem hiding this comment.
Thanks for pointing this out. I think its fine for now, though admittedly its a bit confusing. No one would install llvm-flang for its own sake. This package will probably go away in the near future because the developers are creating a monorepo for the classic flang. So in summary, I think its OK as is.
3 participants
Update preferred version of Flang and update the dependencies in LLVM-Flang.
@gklimowicz @trws