Support external find for gpgme.#18594
Merged
adamjstewart merged 1 commit intospack:developfrom Sep 9, 2020
Merged
Conversation
adamjstewart
reviewed
Sep 9, 2020
Comment on lines
+27
to
+29
| output = Executable(exe)('--version', output=str, error=str) | ||
| match = re.search(r'(\S+)', output) | ||
| return match.group(1) if match else None |
Member
There was a problem hiding this comment.
Suggested change
| output = Executable(exe)('--version', output=str, error=str) | |
| match = re.search(r'(\S+)', output) | |
| return match.group(1) if match else None | |
| return Executable(exe)('--version', output=str, error=str).rstrip() |
This is how I do it in the GDAL package.
Contributor
Author
There was a problem hiding this comment.
Thanks, that is much easier.
paulbry
force-pushed
the
gpgme-external-find
branch
from
1797213 to
9295b5d
Compare
paulbry
force-pushed
the
gpgme-external-find
branch
from
9295b5d to
acf1696
Compare
adamjstewart
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for
external findcommand to thegpgmepackage: