audacious: Add gettext and iconv dependency.#18584
Merged
alalazo merged 2 commits intospack:developfrom Sep 9, 2020
Merged
Conversation
adamjstewart
approved these changes
Sep 9, 2020
alalazo
approved these changes
Sep 9, 2020
alalazo
requested changes
Sep 9, 2020
Comment on lines
+25
to
+28
| depends_on('gettext', type=('build', 'link')) | ||
| depends_on('iconv', type='link') | ||
| depends_on('glib', type='link') | ||
| depends_on('qt', type='link') |
Member
There was a problem hiding this comment.
Can we remove types from these dependencies and use the default, which seems to fit? If instead we want for some reason to stick with these, isn't qt a build,link dependency due to the presence of MOC and similar machinery?
alalazo
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audacious use gettext and iconv, but not dependency.
This PR add gettext and iconv dependency.