Modules: Fix configuration overriding#18514
Merged
alalazo merged 2 commits intospack:developfrom Sep 9, 2020
Merged
Conversation
Contributor
Author
|
The unitttests are failing because commit e743726 from PR #18351 is required to have the same behavior as main Spack. I can either push this commit to this PR or wait for the first PR to be merge before rebasing this one. |
Member
|
@RemiLacroix-IDRIS Let's wait for #18315 to go in and then rebase this PR. |
This is a special case of overriding since each section is being matched with the current spec. The trailing ':' for sections with override is now removed when parsing the configuration so the special handling for the modules configuration stopped working but it went unnoticed.
RemiLacroix-IDRIS
force-pushed
the
modules_config_override
branch
from
c2ce2aa to
cd078b8
Compare
Contributor
Author
Done. The unittests passed as expected (except for the MacOS ones but for an unrelated reason). |
alalazo
approved these changes
Sep 9, 2020
Member
|
Thanks! |
Contributor
Author
|
You're welcome. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got broken some times ago but nobody noticed.