modified:fftw/package.py,new file:a64fx-3.3.8.patch#18437
Closed
hirashima-ryota wants to merge 1 commit intospack:developfrom
Closed
modified:fftw/package.py,new file:a64fx-3.3.8.patch#18437hirashima-ryota wants to merge 1 commit intospack:developfrom
hirashima-ryota wants to merge 1 commit intospack:developfrom
Conversation
alalazo
requested changes
Sep 1, 2020
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
There are changes in this PR that undo previous PRs. Was that on purpose?
| patch('pfft-3.3.4.patch', when="@3.3.4+pfft_patches", level=0) | ||
| patch('pgi-3.3.6-pl2.patch', when="@3.3.6-pl2%pgi", level=0) | ||
| patch('intel-configure.patch', when="@3:3.3.8%intel", level=0) | ||
| patch('a64fx-3.3.8.patch', when="@3.3.8 target=a64fx") |
Member
There was a problem hiding this comment.
Can you provide a reference where this patch is discussed? Asking since the patch changes ~8k lines in the sources. Will it be accepted upstream for future releases?
Member
There was a problem hiding this comment.
(See #18349 (comment) for the initial discussion on the question above)
Member
|
Duplicate of #18349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for causing conflict.
fftw(v3.3.8) tunning version for a64fx(fj 4.2.0).
modified:fftw/package.py
new file:a64fx-3.3.8.patch