modified:fftw/package.py,new file:a64fx-3.3.8.patch#18349
modified:fftw/package.py,new file:a64fx-3.3.8.patch#18349hirashima-ryota wants to merge 1 commit intospack:developfrom
Conversation
|
Can you rebase on develop? There are some conflicts and some of your changes undo changes in develop. |
| patch('pfft-3.3.5.patch', when="@3.3.5:+pfft_patches", level=0) | ||
| patch('pfft-3.3.4.patch', when="@3.3.4+pfft_patches", level=0) | ||
| patch('pgi-3.3.6-pl2.patch', when="@3.3.6-pl2%pgi", level=0) | ||
| patch('a64fx-3.3.8.patch', when="@3.3.8 target=a64fx") |
There was a problem hiding this comment.
Can you provide a reference where this patch is discussed? Asking since the patch changes ~8k lines in the sources. Will it be accepted upstream for future releases?
There was a problem hiding this comment.
FWIW, the patch is quite big because it modifies a bunch of files that are automatically generated, so it would be much easier to review the patch vs the FFTW/fftw3 repo.
That being said, such a patch would not be a fit for spack since the FFTW bootstrap.sh is a dependency hell (including an old ocaml version that supports a removed module) and spack should keep building fftw from a tarball.
There was a problem hiding this comment.
FWIW, the patch is quite big because it modifies a bunch of files that are automatically generated, so it would be much easier to review the patch vs the FFTW/fftw3 repo
I concur, my question was more like to know if such a PR was submitted upstream to the FFTW repo and if it's worth to get it merged there and then use the latest release, in particular considering that it's likely that a new release will be tagged soon: FFTW/fftw3#210
|
sorry.this request is closed. |
|
We do add some large patches although the only one of comparable size is at #4783 (although that is a patch for a single version, and that patch was later upstreamed to the I have a couple questions:
|
|
Thank you for your comment.
Humm.... I think it can be used unless it is a major fix, but I think it should not be applied without testing.
It's too Fujitsu compiler specific modification to add this fix to the official FFTW repository and It's probably unacceptable for FFTW community. |
6 participants
fftw(3.3.8) tunning for Fujitsu Compiler(a64fx)
modified:fftw/package.py
new file:a64fx-3.3.8.patch