Closed
Conversation
alalazo
reviewed
Aug 27, 2020
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
LGTM, modulo one minor request
Comment on lines
+23
to
+24
| depends_on('py-numpy', type=('build', 'run')) | ||
| depends_on('py-cython', type=('build', 'run')) |
Member
There was a problem hiding this comment.
Ugh, it's quite difficult to say if the list of deps is correct looking through here. Can you please double check or confirm you can install this on some platform?
Member
There was a problem hiding this comment.
Also, the cython dependency is likely only needed at build-time.
Member
|
Closing as stale. Feel free to reopen if you want to push this PR forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.