Skip to content

Remove support for BlueGene/Q#17729

Merged
tgamblin merged 3 commits intodevelopfrom
features/remove_support_for_blue_gene
Aug 11, 2020
Merged

Remove support for BlueGene/Q#17729
tgamblin merged 3 commits intodevelopfrom
features/remove_support_for_blue_gene

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jul 28, 2020

Only a few BlueGene/Q remain in the top 500 and both Vulcan and Sequoia have been decommissioned. This PR removes support for BlueGene/Q in both core Spack and builtin packages.

It can be merged as soon as there is agreement that we can deprecate support for BlueGene/Q.

@alalazo alalazo mentioned this pull request Jul 28, 2020
Closed
7 tasks
@alalazo alalazo force-pushed the features/remove_support_for_blue_gene branch from 4b8a8c8 to 6c5fe90 Compare July 30, 2020 12:56
@alalazo alalazo marked this pull request as ready for review July 30, 2020 17:49
tldahlgren
tldahlgren approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only question is if you want to make additional related changes in this PR?

@tldahlgren tldahlgren self-requested a review July 30, 2020 18:23
tldahlgren
tldahlgren requested changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to make related changes in the files listed below in the previous commit in this or a separate PR?

  • docs/basic_usage.rst
  • docs/features.rst
  • llnl/util/lang.py
  • spack/compiler.py
  • spack/spec.py

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Jul 31, 2020

@tldahlgren I think I changed all the places mentioning bgq in the docs. Let me know if you see others. Thanks for the review!

tldahlgren
tldahlgren approved these changes Jul 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catches on updating some of the API docstrings!

@tldahlgren
Copy link
Copy Markdown
Contributor

tldahlgren commented Jul 31, 2020

Note the brew issue and what appears to be a hung Waiting for status to be reported issue (for centos6) are affecting required checks ATM.

@alalazo alalazo closed this Aug 1, 2020
@alalazo alalazo reopened this Aug 1, 2020
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Aug 1, 2020

Note the brew issue and what appears to be a hung Waiting for status to be reported issue (for centos6) are affecting required checks ATM.

Merged a fix for MacOS and re-run tests. It seems everything but e4s is green now but e4s is failing also on develop. I need to check why but wouldn't consider that essential here. Imo this is ready to be triggered as soon as we want to 👋 BG/Q

@becker33
Copy link
Copy Markdown
Member

becker33 commented Aug 10, 2020

The e4s failure is because of conduit ^hdf5~hl not playing nicely with the newest version of cmake. Conduit developers and cmake developers are aware of it and I'm sure we'll have a fix soon, in the meantime @eugeneswalker is working on a version constraint to avoid the versions that don't play nicely together

@tgamblin tgamblin merged commit 1dba0ce into develop Aug 11, 2020
@alalazo alalazo deleted the features/remove_support_for_blue_gene branch August 11, 2020 05:45
@adamjstewart adamjstewart mentioned this pull request Oct 11, 2020
Merged
@alalazo alalazo mentioned this pull request Nov 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgamblin tgamblin tgamblin approved these changes

@tldahlgren tldahlgren tldahlgren approved these changes

Assignees

No one assigned

Labels

maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alalazo @tldahlgren @becker33 @tgamblin