bugfix: ignore Apple's "gcc" by default#17589
Merged
Conversation
alalazo
approved these changes
Jul 19, 2020
tgamblin
force-pushed
the
fix-apple-gcc-detection
branch
from
8c24055 to
20e136b
Compare
Member
Author
|
Another weirdness: when apple The "Configured with..." line is new to me. I tweaked the regex to be multi-line to handle this. |
tgamblin
force-pushed
the
fix-apple-gcc-detection
branch
2 times, most recently
from
e1a50b6 to
338b20a
Compare
Apple's gcc is really clang. We previously ignored it by default but there was a regression in #17110. Originally we checked for all clang versions with this, but I know of none other than `gcc` on macos that actually do this, so limiting to `apple-clang` should be ok. - [x] Fix check for `apple-clang` in `gcc.py` to use version detection from `spack.compilers.apple_clang`
tgamblin
force-pushed
the
fix-apple-gcc-detection
branch
from
338b20a to
c681609
Compare
becker33
pushed a commit
that referenced
this pull request
Jul 23, 2020
Apple's gcc is really clang. We previously ignored it by default but there was a regression in #17110. Originally we checked for all clang versions with this, but I know of none other than `gcc` on macos that actually do this, so limiting to `apple-clang` should be ok. - [x] Fix check for `apple-clang` in `gcc.py` to use version detection from `spack.compilers.apple_clang`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple's gcc is really clang. We previously ignored it by default but there was a regression in #17110.
Originally we checked for all clang versions with this, but I know of none other than
gccon macos that actually do this, so limiting toapple-clangshould be ok.apple-clangingcc.pyto use version detection fromspack.compilers.apple_clang