Skip to content

Bugfix/install missing compiler from buildcache#17536

Merged
tldahlgren merged 2 commits intodevelopfrom
bugfix/install-missing-compiler-from-buildcache
Jul 17, 2020
Merged

Bugfix/install missing compiler from buildcache#17536
tldahlgren merged 2 commits intodevelopfrom
bugfix/install-missing-compiler-from-buildcache

Conversation

@scottwittenburg
Copy link
Copy Markdown
Contributor

This PR fixes an issue I (and others) have seen when running compiler bootstrapping pipelines using the spack ci sub-commands. The first commit here adds a test that mimics what we do in pipelines, where the bootstrapped compiler is installed and put into a binary mirror in some stage of the pipeline, and then in a later stage, we attempt to use install-missing-compilers: true to have that compiler installed from the binary mirror during installation of the spec that needs it.

Without the fix in the second commit, the test in the first commit fails with the message:

spack.installer.InstallError: Cannot proceed with b: 1 uninstalled dependency: gcc

... which corresponds to the issue I've seen in pipeline logs.

@scottwittenburg
Copy link
Copy Markdown
Contributor Author

@haampie For me this fixes the issue you reported on slack, where your attempt to bootstrap compilers to build readline failed. Feel free to test it out and let me know if it solves that issue for you.

@scottwittenburg scottwittenburg force-pushed the bugfix/install-missing-compiler-from-buildcache branch from 94ba784 to cfd4a1d Compare July 14, 2020 22:55
@scottwittenburg
Copy link
Copy Markdown
Contributor Author

Whoops, I guess I had a gpg key trusted locally that prevented me from seeing the issue revealed here. But I removed it, and updated the buildcache creation and installation therefrom so they should work with out any need for a key. I guess we'll see though...

@adamjstewart adamjstewart added bugfix Something wasn't working, here's a fix buildcache labels Jul 15, 2020
@haampie
Copy link
Copy Markdown
Member

haampie commented Jul 15, 2020

Can confirm this makes things work for me, thanks!

To make everything work I need the following patches currently:

Hopefully they can all be merged.

--

Edit: maybe that was a false positive actually... I just realized the pipeline succeeded because all dependencies were in the binary cache already. Let me retry.

Edit 2: it still does not solve the problem :( details in #17544

@scottwittenburg
Copy link
Copy Markdown
Contributor Author

Sadly, issues seem to remain with compiler bootstrapping pipeline, though this patch was needed in order to reveal the next problem. I'll continue to investigate.

@scottwittenburg
Copy link
Copy Markdown
Contributor Author

FYI @zackgalbreath and @tgamblin The workflow I set up for the spack-tutorial-container project depends on compiler bootstrapping, so this is important at the moment. I'm still trying to figure out exactly what we need for it to work again, but @haampie and I have been iterating on several issues that have cropped up while we weren't running any of those pipelines.

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like slate is failing (as usual?) for e4s.

Just checking if the tests work for me on an LC system.

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed tests pass on an LC machine.

@tldahlgren tldahlgren merged commit b5f8269 into develop Jul 17, 2020
@tldahlgren
Copy link
Copy Markdown
Contributor

Thank you for your contribution.

@scottwittenburg
Copy link
Copy Markdown
Contributor Author

LGTM. Looks like slate is failing (as usual?) for e4s.

Yes, slate started failing this week after the cuda 11 update went in, and although we fixed that in E4S by making slate depend specifically on the previous version of cuda, I didn't push this branch again after I made that fix. Thanks for noticing though, I'm glad folks are looking at those builds 😄

Just checking if the tests work for me on an LC system.

Awesome, thanks taking the time to check that.

And thanks for the review and merge!

becker33 pushed a commit that referenced this pull request Jul 23, 2020
Ensure compilers installed from buildcache are registered.
@junghans junghans deleted the bugfix/install-missing-compiler-from-buildcache branch August 19, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix buildcache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants