Skip to content

Relocation of sbang needs to be done when the spack prefix changes even if the install tree has not changed.#17455

Merged
gartung merged 1 commit intodevelopfrom
gartung-buildcache-sbang-relocate-fix
Jul 10, 2020
Merged

Relocation of sbang needs to be done when the spack prefix changes even if the install tree has not changed.#17455
gartung merged 1 commit intodevelopfrom
gartung-buildcache-sbang-relocate-fix

Conversation

@gartung
Copy link
Copy Markdown
Member

@gartung gartung commented Jul 10, 2020

Not sure how to do a unit test on this one. It requires using the same install_tree but using a different spack directory when installing the buildcache.

@eugeneswalker
Copy link
Copy Markdown
Contributor

This resolved the issue I was having! Thanks!

Copy link
Copy Markdown
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have tests (but as we discussed in slack, that's going to have to stay a work in progress.

@gartung gartung merged commit e72e256 into develop Jul 10, 2020
@becker33
Copy link
Copy Markdown
Member

@tgamblin this is the other PR that @gartung just mentioned

@gartung gartung deleted the gartung-buildcache-sbang-relocate-fix branch July 27, 2020 18:34
tgamblin pushed a commit that referenced this pull request Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buildcache: relocation of binaries is broken when $padding is used in the install_tree config variable.

4 participants