Closed
Conversation
8a15740 to
b81fb77
Compare
3 tasks
The tokenizer already works correctly for specs like "hdf5 ^mpi=mpich". Fixed an issue with error messages.
At the moment the spec semantics still discards the bindings but allows it syntactically.
Previously it was not possible to bind only a part of the virtual dependencies that a spec provided. This commit makes it such that a user can specify an explicit binding for each virtual dependency separately.
Packages can now declare virtual dependencies that needs to be provided together (e.g. "lapack" and "blas" in openblas). If virtual dependencies are declared as part of the same "provides" directive, then they will be provided together.
Each edge in the DAG now contains an additional attribute that is used to track which virtual dependencies are satisfied by the edge. This attribute is only added, but not used, in this commit.
This commit permits to parse specs that bind multiple virtual dependencies to the same spec e.g. "netlib-scalapack ^lapack,blas=openblas"
As per a discussion with Todd, saying "used together" conveys better the meaning of this dictionary.
The root spec byte blob is now generated on the fly for tests.
This should help to better convey the meaning of this attribute i.e. store somewhere the user requested providers so that we can honor those requests when concretizing.
b81fb77 to
3888dbe
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased version of the branch in #15569 pushed upstream to trigger e4s builds.