Skip to content

Test 15569 on e4s pipeline#17439

Closed
alalazo wants to merge 31 commits intodevelopfrom
features/finer_virtual_selection
Closed

Test 15569 on e4s pipeline#17439
alalazo wants to merge 31 commits intodevelopfrom
features/finer_virtual_selection

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jul 9, 2020

This is a rebased version of the branch in #15569 pushed upstream to trigger e4s builds.

@alalazo alalazo added the tests General test capability(ies) label Jul 9, 2020
@alalazo alalazo force-pushed the features/finer_virtual_selection branch 2 times, most recently from 8a15740 to b81fb77 Compare July 13, 2020 08:24
alalazo added 26 commits July 13, 2020 21:36
The tokenizer already works correctly for specs like
"hdf5 ^mpi=mpich". Fixed an issue with error messages.
At the moment the spec semantics still discards the
bindings but allows it syntactically.
Previously it was not possible to bind only a part
of the virtual dependencies that a spec provided.
This commit makes it such that a user can specify
an explicit binding for each virtual dependency
separately.
Packages can now declare virtual dependencies that needs to
be provided together (e.g. "lapack" and "blas" in openblas).
If virtual dependencies are declared as part of the same
"provides" directive, then they will be provided together.
Each edge in the DAG now contains an additional attribute
that is used to track which virtual dependencies are
satisfied by the edge.

This attribute is only added, but not used, in this commit.
This commit permits to parse specs that bind
multiple virtual dependencies to the same spec
e.g. "netlib-scalapack ^lapack,blas=openblas"
As per a discussion with Todd, saying "used together" conveys
better the meaning of this dictionary.
The root spec byte blob is now generated on the fly
for tests.
This should help to better convey the meaning of this attribute
i.e. store somewhere the user requested providers so that we
can honor those requests when concretizing.
@alalazo alalazo force-pushed the features/finer_virtual_selection branch from b81fb77 to 3888dbe Compare July 13, 2020 19:36
@alalazo alalazo closed this Sep 24, 2020
@alalazo alalazo deleted the features/finer_virtual_selection branch September 24, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant