Skip to content

New package: alps#17023

Merged
scheibelp merged 20 commits intospack:developfrom
Sinan81:package/alps
Jun 12, 2020
Merged

New package: alps#17023
scheibelp merged 20 commits intospack:developfrom
Sinan81:package/alps

Conversation

@Sinan81
Copy link
Copy Markdown
Contributor

@Sinan81 Sinan81 commented Jun 9, 2020

A computational physics package.

Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. In general there are instructions here that don't match what is encoded in the package. Are the build instruction on the official site outdated?

@Sinan81
Copy link
Copy Markdown
Contributor Author

Sinan81 commented Jun 10, 2020

I left a few comments. In general there are instructions here that don't match what is encoded in the package. Are the build instruction on the official site outdated?

Yep! Build instructions are super outdated!

@Sinan81
Copy link
Copy Markdown
Contributor Author

Sinan81 commented Jun 11, 2020

I wonder if we could have used CXX_STANDARD option in CMAKE instead? https://cmake.org/cmake/help/v3.1/prop_tgt/CXX_STANDARD.html

Oh well, the package builds, so let's merge it.

@scheibelp scheibelp merged commit f44a93e into spack:develop Jun 12, 2020
likask pushed a commit to likask/spack that referenced this pull request Jun 15, 2020
* commit '1501de59ed74802f48e32b0657fc6c95997b264a': (3648 commits)
  Package/py-lmfit: add new version (spack#16975)
  hpctoolkit: add version 2020.06.12 (spack#17081)
  add dependency for icd variant, or else build fails (spack#17079)
  clang: add 'version_argument', remove redundant method (spack#17071)
  New package: ocl-icd (spack#17078)
  Reframe 3.0 (spack#17005)
  py-healpy: a new package. (spack#17001)
  New recipe for building the Log4C package (spack#17038)
  fix depends issue and support for aarch64 (spack#17045)
  replace 'no' with 'none' as possible value of 'threads' variant (spack#17063)
  xrootd: new versions (spack#17076)
  add compilers to mpi setup_run_environment methods forall mpi implementations (spack#17015)
  bazel: patch to allow py-tensorflow (and likely other bazel packages) to build. (spack#17013)
  New package: FrontFlow Blue (spack#16901)
  cscope: Link tinfow instead of tinfo
  New package: alps (spack#17023)
  pygpu: fix linking with gpuarray (spack#17033)
  libtree package: add version 1.2.0, 1.1.4, and 1.1.3 (spack#17035)
  Buildcache: Fix bug in binary string replacement (spack#17075)
  New package: clinfo (spack#17042)
  ...

# Conflicts:
#	.gitignore
#	lib/spack/spack/binary_distribution.py
#	lib/spack/spack/modules/common.py
#	var/spack/repos/builtin/packages/med/package.py
#	var/spack/repos/builtin/packages/mofem-cephas/package.py
#	var/spack/repos/builtin/packages/mofem-fracture-module/package.py
#	var/spack/repos/builtin/packages/mofem-users-modules/package.py
#	var/spack/repos/builtin/packages/petsc/package.py
#	var/spack/repos/builtin/packages/python/package.py
manifestoso pushed a commit to DeepThoughtHPC/spack that referenced this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants