Skip to content

update darshan-runtime & darshan-util versions#16934

Merged
eugeneswalker merged 2 commits intospack:developfrom
shanedsnyder:add-darshan-3.2.1-versions
Jun 4, 2020
Merged

update darshan-runtime & darshan-util versions#16934
eugeneswalker merged 2 commits intospack:developfrom
shanedsnyder:add-darshan-3.2.1-versions

Conversation

@shanedsnyder
Copy link
Copy Markdown

@shanedsnyder shanedsnyder commented Jun 3, 2020

Includes up through the current release, 3.2.1.

Fixes #16930

includes up through the current release, 3.2.1
@eugeneswalker
Copy link
Copy Markdown
Contributor

[email protected] -- added to Spack by this commit -- does not have the same compilation problems as @3.1.8 when built with GCC 9.3.0 (see #16930). Thank you!

@michaelkuhn
Copy link
Copy Markdown
Member

@shanedsnyder If you add "Fixes #16930" to the initial PR comment, @eugeneswalker's issue will get closed automatically once this PR is merged.

@shanedsnyder
Copy link
Copy Markdown
Author

Just update the initial PR message, thanks! And thanks @eugeneswalker for confirming!

Copy link
Copy Markdown
Member

@michaelkuhn michaelkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did test builds of darshan-runtime and darshan-util and everything works fine. Expect for the comments regarding 3.2.0-pre1, this is OK from my side.


version('develop', branch='master')
version('3.2.1', sha256='d63048b7a3d1c4de939875943e3e7a2468a9034fcb68585edbc87f57f622e7f7')
version('3.2.0-pre1', sha256='afc11609420bab99a5f2dd7b4f4aa4c34f5423a5ca438c5f2d444dc3efe6dfa8')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason to include 3.2.0-pre1? It seems to be sorted as newer than 3.2.0, which I guess it is not. I think I would just remove it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call. Definitely should be sorted above 3.2.0, but you're right that there's not really any reason for users to choose the pre-release version over 3.2.0. I just removed it from both packages to avoid confusion.


version('develop', branch='master')
version('3.2.1', sha256='d63048b7a3d1c4de939875943e3e7a2468a9034fcb68585edbc87f57f622e7f7')
version('3.2.0-pre1', sha256='afc11609420bab99a5f2dd7b4f4aa4c34f5423a5ca438c5f2d444dc3efe6dfa8')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@eugeneswalker eugeneswalker merged commit 748be57 into spack:develop Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation issue: Darshan-runtime GCC 9.3.0 Ubuntu 20.04

3 participants