Merged
Conversation
Contributor
h-denpo
commented
Jun 2, 2020
h-denpo
commented
becker33
requested changes
Jun 2, 2020
Member
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
I think this package could be written much more neatly as a MakefilePackage than as a Package.
Additional comments inline.
Contributor
Author
|
Thank you for all your advice. |
Computational Fluid Dynamics Software for aeroacoustics
becker33
requested changes
Jun 12, 2020
Member
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
Mostly this looks really good now.
I have only one request, but it's a somewhat difficult one to explain so I put a code suggestion and a long explanation of what that code does. Let me know if you think that will not work and I'm okay with revisiting it, but I think this well help you allow users to set the compiler flags while maintaining your defaults.
Co-authored-by: Greg Becker <[email protected]>
Co-authored-by: Greg Becker <[email protected]>
becker33
approved these changes
Jun 12, 2020
likask
pushed a commit
to likask/spack
that referenced
this pull request
Jun 15, 2020
* commit '1501de59ed74802f48e32b0657fc6c95997b264a': (3648 commits) Package/py-lmfit: add new version (spack#16975) hpctoolkit: add version 2020.06.12 (spack#17081) add dependency for icd variant, or else build fails (spack#17079) clang: add 'version_argument', remove redundant method (spack#17071) New package: ocl-icd (spack#17078) Reframe 3.0 (spack#17005) py-healpy: a new package. (spack#17001) New recipe for building the Log4C package (spack#17038) fix depends issue and support for aarch64 (spack#17045) replace 'no' with 'none' as possible value of 'threads' variant (spack#17063) xrootd: new versions (spack#17076) add compilers to mpi setup_run_environment methods forall mpi implementations (spack#17015) bazel: patch to allow py-tensorflow (and likely other bazel packages) to build. (spack#17013) New package: FrontFlow Blue (spack#16901) cscope: Link tinfow instead of tinfo New package: alps (spack#17023) pygpu: fix linking with gpuarray (spack#17033) libtree package: add version 1.2.0, 1.1.4, and 1.1.3 (spack#17035) Buildcache: Fix bug in binary string replacement (spack#17075) New package: clinfo (spack#17042) ... # Conflicts: # .gitignore # lib/spack/spack/binary_distribution.py # lib/spack/spack/modules/common.py # var/spack/repos/builtin/packages/med/package.py # var/spack/repos/builtin/packages/mofem-cephas/package.py # var/spack/repos/builtin/packages/mofem-fracture-module/package.py # var/spack/repos/builtin/packages/mofem-users-modules/package.py # var/spack/repos/builtin/packages/petsc/package.py # var/spack/repos/builtin/packages/python/package.py
manifestoso
pushed a commit
to DeepThoughtHPC/spack
that referenced
this pull request
Jun 19, 2020
* New package: FrontFlow Blue
Computational Fluid Dynamics Software for aeroacoustics
* Modify Package ->MakefilePackage
* Update var/spack/repos/builtin/packages/ffb/package.py
Co-authored-by: Greg Becker <[email protected]>
* Update var/spack/repos/builtin/packages/ffb/package.py
Co-authored-by: Greg Becker <[email protected]>
Co-authored-by: Greg Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.