Conversation
|
No idea why the build is failing-- it seems to be related to tty echoing, which my package doesn't touch. Are the unit tests bugged? |
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
This basically LGTM, the only request for change is on variants. Can we either add them explicitly or put TODO comments where non-existing variants are checked in the recipe?
That single unit test, as far as I know, is non-deterministic - so sometimes it fails spuriously. I just restarted the MacOS tests and am quite confident they'll succeed this time. |
There was a problem hiding this comment.
@rblake-llnl we have a nice helper method for defining CMake variables from variants, this could clean the code up a fair bit (for the ones that don't require special handling).
Co-authored-by: Greg Becker <[email protected]>
Co-authored-by: Greg Becker <[email protected]>
|
Thanks for the tips, @becker33 ! I merged your changes. |
4 participants
Libraries and bindings for the Systems Biology Markup Language.
I only added python support variants, but additional support for other languages could also be added.