Split hepmc Into hepmc and hepmc3#16892
Conversation
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
It looks like you missed some changes to make to hepmc, unless those were simultaneous bugfixes.
Otherwise LGTM
| depends_on('python', when='+python') | ||
| depends_on('root', when='+rootio') |
There was a problem hiding this comment.
It looks (from the conflicts removed below) like neither of these should be valid dependencies for hepmc when we split out hepmc3
There was a problem hiding this comment.
good catch, indeed I removed the variants but overlooked those two lines. Fixed.
|
@becker33 is the build failure is related to my changes or something unrelated? |
|
The build failure is unrelated, apple release a patch for macos that broke one of our tests when it was integrated into github actions (interestingly, the test succeeds when run directly on a macbook with the patch). We're working on fixing that, and in the meantime merging things despite failures of that particular test. |
| @@ -27,51 +22,14 @@ class Hepmc(CMakePackage): | |||
| version('2.06.05', sha256='4c411077cc97522c03b74f973264b8d9fd2b6ccec0efc7ceced2645371c73618') | |||
|
|
|||
| variant('python', default=False, description='Enable Python bindings') | |||
There was a problem hiding this comment.
I think this variant still needs to be deleted.
There was a problem hiding this comment.
Can't believe I overlooked that again! Fixed, thanks.
3 participants
Since HepMC3 is basically an indepependent package from HepMC2, this splits the recipes, as discussed in #16880, which adds some generators that can use hepmc and hepmc3 concurrently.