Ignore __pycache__ directory#16836
Merged
adamjstewart merged 1 commit intospack:developfrom Jun 4, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying out Spack on Windows using the Ubuntu WSL, which contains Python 3.8. So far, everything works fine, but I noticed the following untracked directory:
There are
__pycache__directories throughout Spack, but they are normally ignored because we ignore*.pycfiles. In this case, the offending directory contains aexceptions.cpython-38.pyc.140647793774000file. I don't know if this is specific to Python 3.8, but https://github.com/github/gitignore/blob/master/Python.gitignore includes__pycache__, so we should too.Honestly, we should probably copy all of https://github.com/github/gitignore/blob/master/Python.gitignore into our
.gitignore. Let me know if you want me to do that.