libxv: Issue #16820, make videoproto a link dependency#16821
Merged
alalazo merged 2 commits intospack:developfrom May 27, 2020
payerle:libxv-16820
Merged
libxv: Issue #16820, make videoproto a link dependency#16821alalazo merged 2 commits intospack:developfrom payerle:libxv-16820
alalazo merged 2 commits intospack:developfrom
payerle:libxv-16820
Conversation
See all issue #16820 libxv includes Xvlib.h, which has a line which is part of videoproto package But had videoproto as a build dependency only. This patch makes it a link dependency as well as build dependency.
alalazo
reviewed
May 27, 2020
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
(build, link) is the default, thus the explicit type can be omitted.
Co-authored-by: Massimiliano Culpo <[email protected]>
alalazo
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See all issue #16820
libxv includes Xvlib.h, which has a line
which is part of videoproto package
But had videoproto as a build dependency only.
This patch makes it a link dependency as well as build dependency.