Skip to content

Add ipython 7.5.0#16801

Merged
adamjstewart merged 3 commits intospack:developfrom
iarspider:patch-1
Jun 2, 2020
Merged

Add ipython 7.5.0#16801
adamjstewart merged 3 commits intospack:developfrom
iarspider:patch-1

Conversation

@iarspider
Copy link
Copy Markdown
Contributor

@iarspider iarspider commented May 25, 2020

No description provided.

adamjstewart
adamjstewart requested changes May 31, 2020
View reviewed changes
@iarspider iarspider requested a review from adamjstewart May 31, 2020 09:14
adamjstewart
adamjstewart reviewed May 31, 2020
View reviewed changes
@iarspider iarspider requested a review from adamjstewart June 1, 2020 20:26
@adamjstewart adamjstewart merged commit 9a17d48 into spack:develop Jun 2, 2020
@scottwittenburg
Copy link
Copy Markdown
Contributor

scottwittenburg commented Jun 2, 2020

The gitlab.spack.io pipeline that ran after this was merged failed, I think as a result of picking up this latest version of ipython. An excerpt from the pipeline log is pasted below:

usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: option --single-version-externally-managed not recognized
==> [2020-06-02-20:30:59.234999, 203] WRITE LOCK (spack-stage-py-ipython-7.5.0-campmtpyfpawfjnywq7k2mfpxusqhyf4): /tmp/root/spack-stage/.lock[3586592708006637623:1] [Releasing] (reads 0, writes 1)
==> [2020-06-02-20:30:59.235225, 203] WRITE LOCK (spack-stage-py-ipython-7.5.0-campmtpyfpawfjnywq7k2mfpxusqhyf4): /tmp/root/spack-stage/.lock[3586592708006637623:1] [Released at 20:30:59.235203] (reads 0, writes 0)
==> [2020-06-02-20:30:59.244004, 197] Error: ProcessError: Command exited with status 1:
    '/home/software/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_/linux-ubuntu18.04-x86_64/gcc-7.3.0/python-3.7.7-par2d2bu35xeq7y6xh4vwolxmfvcph7j/bin/python3.7' '-s' 'setup.py' '--no-user-cfg' 'install' '--prefix=/home/software/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_path_placeholder/spack_/linux-ubuntu18.04-x86_64/gcc-7.3.0/py-ipython-7.5.0-campmtpyfpawfjnywq7k2mfpxusqhyf4' '--single-version-externally-managed' '--root=/'

1 error found in build log:
     352      warnings.warn(msg)
     353    usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ..
            .]
     354       or: setup.py --help [cmd1 cmd2 ...]
     355       or: setup.py --help-commands
     356       or: setup.py cmd --help
     357    
  >> 358    error: option --single-version-externally-managed not recognized

Does that ring a bell for anyone?

For the moment, I can pin the version of ipython in the E4S environment repo to the previous working version, just to get the pipeline passing again. Unless this is a really quick an easy fix, that is. Thoughts on that, @eugeneswalker?

The full pipeline log is attached.

pipeline_log (95).txt

@eugeneswalker
Copy link
Copy Markdown
Contributor

eugeneswalker commented Jun 2, 2020

I think pinning in the E4S repo to [email protected] is a good idea Scott, at least for the time being, unless someone else has a better idea of how to resolve the error.

@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Jun 2, 2020

That error means that we need to remove the setuptools dependency from ipython, or maybe make it a run-dependency.

We add that flag in PythonPackage whenever we have a build dependency on setuptools. That flag is only valid when setup.py uses setuptools. It looks like setup.py says:

install_requires = [
    'setuptools>=18.5',

but doesn't actually import setuptools unless certain setup.py <phase> selections are chosen. @iarspider can you look through the ipython history and see when the needs_setuptools logic was added to setup.py? That will be the first version that needs a run dep but not a build dep.

@scottwittenburg
Copy link
Copy Markdown
Contributor

scottwittenburg commented Jun 2, 2020

Thanks for taking a look @adamjstewart, and for describing the issue so clearly.

Once this gets ironed out, I'll remove the pinned ipython version from our test environment.

@adamjstewart adamjstewart mentioned this pull request Jun 3, 2020
Merged
@iarspider iarspider deleted the patch-1 branch June 3, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees

No one assigned

Labels

dependencies new-version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iarspider @scottwittenburg @eugeneswalker @adamjstewart