Conversation
alalazo
left a comment
There was a problem hiding this comment.
A few request for changes. Can you also tag this application as a proxy-app? You can check which others are tagged by looking at:
$ spack list -t proxy-app| """Quicksilver is a proxy application that represents some elements of | ||
| the Mercury workload by solving a simpli?ed dynamic monte carlo | ||
| particle transport problem. Quicksilver attempts to replicate the | ||
| memory access patterns, communication patterns, and the branching or | ||
| divergence of Mercury for problems using multigroup cross sections.""" |
There was a problem hiding this comment.
Can you separate the docstring into a short first sentence and a longer description in another paragraph?
| divergence of Mercury for problems using multigroup cross sections.""" | ||
|
|
||
| homepage = "https://codesign.llnl.gov/quicksilver.php" | ||
| git = "https://github.com/LLNL/Quicksilver.git" |
There was a problem hiding this comment.
According to Quicksilver's Github repository:
Instructions to build Quicksilver can be found in the Makefile. Quicksilver is a relatively easy to build code with no external dependencies (except MPI and OpenMP)
Should we add MPI as a dependency then? Maybe conditional on a variant?
|
Pinging @richards12 in case he's interested in giving a few more hints on how the package for "Quicksilver" should look like. |
|
That's OK, I'll test it on my platform. : ) |
No description provided.