Skip to content

Add new package: quicksilver#16792

Closed
darmac wants to merge 1 commit intospack:developfrom
open-estuary:quicksilver
Closed

Add new package: quicksilver#16792
darmac wants to merge 1 commit intospack:developfrom
open-estuary:quicksilver

Conversation

@darmac
Copy link
Copy Markdown
Contributor

@darmac darmac commented May 25, 2020

No description provided.

Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few request for changes. Can you also tag this application as a proxy-app? You can check which others are tagged by looking at:

$ spack list -t proxy-app

Comment on lines +10 to +14
"""Quicksilver is a proxy application that represents some elements of
the Mercury workload by solving a simpli?ed dynamic monte carlo
particle transport problem. Quicksilver attempts to replicate the
memory access patterns, communication patterns, and the branching or
divergence of Mercury for problems using multigroup cross sections."""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate the docstring into a short first sentence and a longer description in another paragraph?

divergence of Mercury for problems using multigroup cross sections."""

homepage = "https://codesign.llnl.gov/quicksilver.php"
git = "https://github.com/LLNL/Quicksilver.git"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Quicksilver's Github repository:

Instructions to build Quicksilver can be found in the Makefile. Quicksilver is a relatively easy to build code with no external dependencies (except MPI and OpenMP)

Should we add MPI as a dependency then? Maybe conditional on a variant?

@alalazo
Copy link
Copy Markdown
Member

alalazo commented May 25, 2020

Pinging @richards12 in case he's interested in giving a few more hints on how the package for "Quicksilver" should look like.

@junghans
Copy link
Copy Markdown
Contributor

@alalazo I added mpi and openmp support in #16811.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented May 27, 2020

@darmac I went with @junghans version of the package since it was ready to be merged, hope you don't mind (and thanks for all your contributions!)

@darmac
Copy link
Copy Markdown
Contributor Author

darmac commented May 27, 2020

That's OK, I'll test it on my platform. : )

@darmac darmac deleted the quicksilver branch June 15, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants