PyYAML: fix linking to libyaml#16682
Merged
adamjstewart merged 1 commit intospack:developfrom May 18, 2020
Merged
Conversation
adamjstewart
added
linking
update-package
stand-alone-tests
Member
|
Works on my system. |
Contributor
|
It works on my system too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16655
Fixes #16581
@t-karatsu @skosukhin can you test this? I think this should fix everyone's problems. Of course, this PR certainly doesn't preclude #16527, but it's easier to test and affects fewer packages, so we can get it merged more quickly.
I tested with and without
+libyamlon macOS 10.15.4 with Python 3.7.7 and Clang 11.0.3 and this PR works fine for me. Would love to have tests on other systems with other compilers.P.S. Sorry #16301 broke this package for all of you. In reality, the package was broken to begin with, but previously it failed silently and after #16301 it failed completely. I've added myself as a maintainer so hopefully this doesn't happen again.