Add new package: http-post#16678
Merged
adamjstewart merged 2 commits intospack:developfrom May 19, 2020
Merged
Conversation
| homepage = "http://www.acme.com/software/http_post/" | ||
| url = "http://www.acme.com/software/http_post/http_post_18May2018.tar.gz" | ||
|
|
||
| version('18May2018', sha256='981c62bcc5cd12b8531f887b3e3779a63a7b7f370062575cded412865a20ea2c') |
Member
There was a problem hiding this comment.
This will be problematic if anyone ever adds another version, as the version won't sort correctly. I would change the version of 2018-05-18 and either manually specify the URL for each version or use Python's datetime module to convert from one format to another in url_for_version. This is a suggestion, not a requirement, it could wait until someone actually needs another version.
adamjstewart
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.